Fix CRLF Line Ending Typesetting #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoolwinter
requested review from
austincondiff,
FastestMolasses,
EstebanBorai,
tom-ludwig and
matthijseikelenboom
|
@thecoolwinter even though this is already merged, why did you disable Swiftlint for testing? |
|
I often disable it for test files because test files can become long or require long lines for test input. It wasn't necessary here in hindsight. I'll remove it in a future PR to keep things more clean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug that made lines ending with the carriage return line feed (
\r\n) string be typeset incorrectly, adding an extra visible line when one did not exist.Also adds a few simple tests to avoid regression.
Related Issues
Checklist